-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comply with guide for method doc: array.c #3506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have a couple reocmmendations, but they could be done in later commits.
I've added three comments into 54fb8fb. |
@mame, I have moved on from array.c. You can put your changes into a PR if you like. |
@hsbt, @marcandre, @mame: I don't understand. Am I obliged to respond to comments for an already-merged PR? This PR was approved by @jeremyevans, merged in September, and then commented on in November. Also, I didn't ignore the comments. I just asked for them to be put into a new PR. |
I just wanted to let you know that I partially reverted some of your changes because they were wrong. I think your answer "I have moved on from array.c." looked not-responsible a little, but I'm okay if you do not make the same mistake again. |
Sorry, I completely misunderstood the issues here, and am not sure I understand them now. Is there anything I need to do? |
Methods: